Re: [PATCH] xhci: Remove dead code in xhci_move_dequeue_past_td()

From: Mathias Nyman
Date: Fri May 24 2024 - 04:43:15 EST


On 24.5.2024 10.07, Hector Martin wrote:
This codepath is trivially dead, since the function is never called with
a non-NULL td (the only callsite is immediately preceded by a NULL guard).


Yes, thanks, adding to queue.
Comment below tells this was destined to be removed earlier.

- * We shouldn't hit this anymore as cached cancelled TRBs are given back
- * after clearing the cache, but be on the safe side and keep it anyway
- */
- if (!td) {
..

Thanks
Mathias