Re: [PATCH 3/9] x86/mce: Increment MCP count only for timer calls

From: Borislav Petkov
Date: Fri May 24 2024 - 10:54:12 EST


On Thu, May 23, 2024 at 10:56:35AM -0500, Yazen Ghannam wrote:
> MCP count is currently incremented for any call to machine_check_poll().
> Therefore, the count includes calls from the timer, boot-time polling,
> and interrupt handlers.
>
> Only increment the MCP count when called from the timer so as to avoid
> double counting the interrupt handlers.

Well, but, every time the function is called, we did poll the banks.
Sure, the count is part of /proc/interrupts but we did poll the banks in
those other cases too. So I think showing an accurate poll number is
actually representing the truth, no matter where it is shown...

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette