Re: [PATCH 2/2] usb: typec: ucsi: Enable UCSI v2.0 notifications
From: kernel test robot
Date: Fri May 24 2024 - 11:29:03 EST
Hi Diogo,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master next-20240523]
[cannot apply to v6.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Diogo-Ivo/usb-typec-ucsi-Add-new-capability-bits/20240524-190924
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20240524105837.15342-3-diogo.ivo%40tecnico.ulisboa.pt
patch subject: [PATCH 2/2] usb: typec: ucsi: Enable UCSI v2.0 notifications
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240524/202405242305.UrCRaTK0-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240524/202405242305.UrCRaTK0-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405242305.UrCRaTK0-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/usb/typec/ucsi/ucsi.c:1686:10: error: use of undeclared identifier 'UCSI_ENABLE_NTFY_SINK_PATH_STS_CHANGE'
ntfy |= UCSI_ENABLE_NTFY_SINK_PATH_STS_CHANGE;
^
>> drivers/usb/typec/ucsi/ucsi.c:1689:11: error: use of undeclared identifier 'UCSI_ENABLE_NTFY_ATTENTION'
ntfy |= UCSI_ENABLE_NTFY_ATTENTION;
^
>> drivers/usb/typec/ucsi/ucsi.c:1692:11: error: use of undeclared identifier 'UCSI_ENABLE_NTFY_LPM_FW_UPDATE_REQ'
ntfy |= UCSI_ENABLE_NTFY_LPM_FW_UPDATE_REQ;
^
>> drivers/usb/typec/ucsi/ucsi.c:1695:11: error: use of undeclared identifier 'UCSI_ENABLE_NTFY_SECURITY_REQ_PARTNER'
ntfy |= UCSI_ENABLE_NTFY_SECURITY_REQ_PARTNER;
^
>> drivers/usb/typec/ucsi/ucsi.c:1698:11: error: use of undeclared identifier 'UCSI_ENABLE_NTFY_SET_RETIMER_MODE'
ntfy |= UCSI_ENABLE_NTFY_SET_RETIMER_MODE;
^
5 errors generated.
vim +/UCSI_ENABLE_NTFY_SINK_PATH_STS_CHANGE +1686 drivers/usb/typec/ucsi/ucsi.c
1664
1665 static u64 ucsi_get_supported_notifications(struct ucsi *ucsi)
1666 {
1667 u16 features = ucsi->cap.features;
1668 u64 ntfy = UCSI_ENABLE_NTFY_ALL;
1669
1670 if (!(features & UCSI_CAP_ALT_MODE_DETAILS))
1671 ntfy &= ~UCSI_ENABLE_NTFY_CAM_CHANGE;
1672
1673 if (!(features & UCSI_CAP_PDO_DETAILS))
1674 ntfy &= ~(UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE |
1675 UCSI_ENABLE_NTFY_CAP_CHANGE);
1676
1677 if (!(features & UCSI_CAP_EXT_SUPPLY_NOTIFICATIONS))
1678 ntfy &= ~UCSI_ENABLE_NTFY_EXT_PWR_SRC_CHANGE;
1679
1680 if (!(features & UCSI_CAP_PD_RESET))
1681 ntfy &= ~UCSI_ENABLE_NTFY_PD_RESET_COMPLETE;
1682
1683 if (ucsi->version <= UCSI_VERSION_1_2)
1684 return ntfy;
1685
> 1686 ntfy |= UCSI_ENABLE_NTFY_SINK_PATH_STS_CHANGE;
1687
1688 if (features & UCSI_CAP_GET_ATTENTION_VDO)
> 1689 ntfy |= UCSI_ENABLE_NTFY_ATTENTION;
1690
1691 if (features & UCSI_CAP_FW_UPDATE_REQUEST)
> 1692 ntfy |= UCSI_ENABLE_NTFY_LPM_FW_UPDATE_REQ;
1693
1694 if (features & UCSI_CAP_SECURITY_REQUEST)
> 1695 ntfy |= UCSI_ENABLE_NTFY_SECURITY_REQ_PARTNER;
1696
1697 if (features & UCSI_CAP_SET_RETIMER_MODE)
> 1698 ntfy |= UCSI_ENABLE_NTFY_SET_RETIMER_MODE;
1699
1700 return ntfy;
1701 }
1702
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki