Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays

From: Abhinav Kumar
Date: Fri May 24 2024 - 14:20:03 EST




On 5/24/2024 8:01 AM, Junhao Xie wrote:
There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
which cause weston assertions failed.

weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
Assertion `!weston_drm_format_array_find_format(formats, format)' failed.

Signed-off-by: Junhao Xie <bigfoot@xxxxxxxxxxx>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------
1 file changed, 6 deletions(-)


I think we need two fixes tag here, one for the RGB array and the other one for the RGB+YUV array.

Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays for rgb and yuv")

Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog")

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

(pls ignore the line breaks in the fixes line, I will fix it while applying)