Re: [PATCH 5/6] platform/chrome: cros_ec_lpc: Correct ACPI name for Framework Laptop

[Ben Walsh]

Dustin Howett <dustin@xxxxxxxxxx> writes:

> On Fri, May 24, 2024 at 1:35 PM Ben Walsh <ben@xxxxxxxxxx> wrote:
>>
>> I could add a new quirk which provides an alternative ACPI match table
>> to be used instead of the default. In the default case the match_table
>> will contain only "GOOG0004" as before. But in the Framework EC case the
>> match table will be "PNP0C09".
>
> My biggest concern with putting PNP0C09 in the direct match table is
> that it would cause cros_ec_lpcs to be loaded for *all* devices with
> an ACPI-compatible embedded controller; it would likely print an error
> and bail out early on, but it would still be unnecessary on 99% of
> platforms.

That's exactly what we're talking about: how to *avoid* putting PNP0C09
in the match table.

My original idea was to put it in the match table, but only allow a
match to proceed if Framework EC is detected by DMI.

My new idea is to not to put it in the match table *at all*, but to
provide a new match table if Framework EC is detected by DMI.