Re: [PATCH] wifi: mwifiex: fix parsing of more than two AKM suites
From: kernel test robot
Date: Fri May 24 2024 - 18:17:49 EST
Hi Sascha,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.9 next-20240523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sascha-Hauer/wifi-mwifiex-fix-parsing-of-more-than-two-AKM-suites/20240523-161947
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20240523081428.2852276-1-s.hauer%40pengutronix.de
patch subject: [PATCH] wifi: mwifiex: fix parsing of more than two AKM suites
config: x86_64-randconfig-122-20240525 (https://download.01.org/0day-ci/archive/20240525/202405250631.g417GL0g-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/202405250631.g417GL0g-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405250631.g417GL0g-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/wireless/marvell/mwifiex/uap_cmd.c:54:17: sparse: sparse: cast to restricted __le16
drivers/net/wireless/marvell/mwifiex/uap_cmd.c:72:17: sparse: sparse: cast to restricted __le16
vim +54 drivers/net/wireless/marvell/mwifiex/uap_cmd.c
27
28 static void woal_check_rsn_ie(const struct IEEEtypes_Rsn_t *rsn_ie, int len,
29 struct mwifiex_uap_bss_param *bss_config, u8 *pairwise_cipher)
30 {
31 int left, count, i;
32 struct wpa_suite_ucast *key_mgmt;
33
34 left = len;
35 if (left < (int)sizeof(struct IEEEtypes_Rsn_t))
36 return;
37
38 bss_config->wpa_cfg.group_cipher = 0;
39 *pairwise_cipher = 0;
40 bss_config->key_mgmt = 0;
41
42 /* check the group cipher */
43 switch (be32_to_cpu(rsn_ie->group_cipher)) {
44 case WLAN_CIPHER_SUITE_TKIP:
45 bss_config->wpa_cfg.group_cipher = CIPHER_TKIP;
46 break;
47 case WLAN_CIPHER_SUITE_CCMP:
48 bss_config->wpa_cfg.group_cipher = CIPHER_AES_CCMP;
49 break;
50 default:
51 break;
52 }
53
> 54 count = le16_to_cpu(rsn_ie->pairwise_cipher.count);
55 for (i = 0; i < count; i++) {
56 switch (be32_to_cpu(rsn_ie->pairwise_cipher.suite[i])) {
57 case WLAN_CIPHER_SUITE_TKIP:
58 *pairwise_cipher |= CIPHER_TKIP;
59 break;
60 case WLAN_CIPHER_SUITE_CCMP:
61 *pairwise_cipher |= CIPHER_AES_CCMP;
62 break;
63 default:
64 break;
65 }
66 }
67 left -= sizeof(struct IEEEtypes_Rsn_t) + (count - 1) * sizeof(__be32);
68 if (left < (int)sizeof(struct wpa_suite_ucast))
69 return;
70
71 key_mgmt = ((void *)rsn_ie + sizeof(struct IEEEtypes_Rsn_t) + (count - 1) * sizeof(__be32));
72 count = le16_to_cpu(key_mgmt->count);
73 if (left < (int)(sizeof(struct wpa_suite_ucast) +
74 (count - 1) * sizeof(__be32)))
75 return;
76
77 for (i = 0; i < count; i++) {
78 switch (be32_to_cpu(key_mgmt->suite[i])) {
79 case WLAN_AKM_SUITE_8021X:
80 bss_config->key_mgmt |= KEY_MGMT_EAP;
81 break;
82 case WLAN_AKM_SUITE_PSK:
83 bss_config->key_mgmt |= KEY_MGMT_PSK;
84 break;
85 case WLAN_AKM_SUITE_PSK_SHA256:
86 bss_config->key_mgmt |= KEY_MGMT_PSK_SHA256;
87 break;
88 case WLAN_AKM_SUITE_SAE:
89 bss_config->key_mgmt |= KEY_MGMT_SAE;
90 break;
91 case WLAN_AKM_SUITE_OWE:
92 bss_config->key_mgmt |= KEY_MGMT_OWE;
93 break;
94 }
95 }
96 }
97
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki