Re: [PATCH 2/3] dt-bindings: hwmon: g76x: Add support for g761

From: Guenter Roeck
Date: Sat May 25 2024 - 15:58:54 EST


On 5/25/24 04:12, Christian Marangi wrote:

Well with how the driver works, if a property is not defined, then the
value is not set and the one set by the bootloader or from device reset
is keept.

This conflicts with the logic of no clock = internal.


Not sure I understand the problem. It would be a simple change in the driver
to add "if the chip is G761 and the clock is not provided in DT, use the
internal clock".


Yes sure code wise is pretty easy, my concern is more of losing this
info in DT. But anyway ok will drop in V2. Thanks a lot for the review!


Not sure I understand. This is added support for a chip which is not currently
supported. There should not be any information to lose. What am I missing ?

Guenter