Re: [GIT PULL] header fix for riscv build failure

From: Kent Overstreet
Date: Sun May 26 2024 - 17:57:59 EST


On Sun, May 26, 2024 at 02:46:04PM -0700, Linus Torvalds wrote:
> On Sun, 26 May 2024 at 10:03, Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
> >
> > Hi Linus, this fixes a riscv randconfig build failure from memory
> > allocation profiling...
>
> This pull request is odd in multiple ways.
>
> (a) it's unsigned, and I really don't pull from unsigned sources any more

I thought it'd be fine since it's a one liner - I'll fix that

> (b) the commit message is strange. It says "bcachefs", but I don't see why

blech, muscle memory...

> (c) you say riscv randconfig in the pull request but then when I
> follow the links in the commit, it says "mips-randconfig". Maybe the
> same thing ends up happening elsewhere too - including riscv - but it
> sure is confusing and I suspect it was just a typo.

Yeah, another typo

> (d) there's no "Fixes:" tag, so then I had to go and look up that
> this wasn't stable material (it doesn't seem to be, the "Fixes" tag
> would seem to be 24e44cc22aa3 ("mm: percpu: enable per-cpu allocation
> tagging") from the current merge window

yeah, I should have added that.

Sorry for the confusion...