Re: [PATCH v3 0/3] Add devicetree support of USB for QDU/QRU1000

[Dmitry Baryshkov]

On Sun, May 26, 2024 at 07:28:42PM -0500, Bjorn Andersson wrote:
> On Thu, May 02, 2024 at 12:09:41PM GMT, Dmitry Baryshkov wrote:
> > On Thu, 2 May 2024 at 12:04, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
> > >
> > > This series adds devicetree nodes to support interconnects and usb for qdu/qru1000.
> > > This is based on previously sent driver series[1].
> > >
> > > ------
> > > Changes in v3:
> > > * As per comments on upstream[2], to get role-switch working on QDU/QRU1000, it was recommended to
> > >   use the actual TI switch driver. Since driver doesn't have the functionality to provide role-switch
> > >   based on gpio, thus reverting back USB dr_mode to peripheral and removed the remote end-point nodes
> > >   and usb-conn-gpio based role switch functionality.
> > 
> > This is not correct. The recommendation was to describe hardware properly.
> > Which means adding schema description, adding  ti,your-switch
> > compatible to the usb-conn-gpio.c driver, etc.
> > 
> 
> In addition to wrangling the ti,switch implementation (and binding) into
> something that only deals with the gpios and not actually talks to the
> chip, this would also require us to add support for fishing out
> vbus-supply of the connector and control that from said driver (or from
> dwc3, or from dwc3-qcom...).
> 
> Given that I find it acceptable to pick up the peripheral-only support
> as presented...

If there will be a followup, I tend to agree here.

For the series:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


> 
> Regards,
> Bjorn
> 
> > > * Link to v2: https://lore.kernel.org/linux-arm-msm/20240319091020.15137-1-quic_kbajaj@xxxxxxxxxxx/
> > >
> > > Changes in v2:
> > > * Changes qmpphy node name
> > > * Changes dr_mode to otg and added USB-B port USB role switch
> > > * Dropped maximum-speed property from usb dwc3 node
> > > * Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120859.18489-1-quic_kbajaj@xxxxxxxxxxx/
> > >
> > > [1] https://lore.kernel.org/linux-arm-msm/20240502082017.13777-1-quic_kbajaj@xxxxxxxxxxx/
> > > [2] https://lore.kernel.org/all/CAA8EJppNZrLzT=vGS0NXnKJT_wL+bMB9jFhJ9K7b7FPgFQbcig@xxxxxxxxxxxxxx/
> > > ------
> > >
> > > Komal Bajaj (3):
> > >   arm64: dts: qcom: qdu1000: Add USB3 and PHY support
> > >   arm64: dts: qcom: qdu1000-idp: enable USB nodes
> > >   arm64: dts: qcom: qru1000-idp: enable USB nodes
> > >
> > >  arch/arm64/boot/dts/qcom/qdu1000-idp.dts |  23 +++++
> > >  arch/arm64/boot/dts/qcom/qdu1000.dtsi    | 120 +++++++++++++++++++++++
> > >  arch/arm64/boot/dts/qcom/qru1000-idp.dts |  23 +++++
> > >  3 files changed, 166 insertions(+)
> > >
> > > --
> > > 2.42.0
> > >
> > >
> > 
> > 
> > -- 
> > With best wishes
> > Dmitry

-- 
With best wishes
Dmitry