Re: [PATCH v3 2/6] thermal: Add support of multi sensors to thermal_core

[Krzysztof Kozlowski]

On 27/05/2024 09:00, Krzysztof Kozlowski wrote:
> On 24/05/2024 16:31, Alexandre Bailon wrote:
>> This adds support of multi sensors to thermal.
>> Currently, this only support the get_temp operation.
>> This returns an average temperature of all the sensors.
>> If defined, a coefficient is applied to the value read from the sensor
>> before computing the average.
>>
>> Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
>> ---
>>  drivers/thermal/Makefile        |   1 +
>>  drivers/thermal/thermal_core.h  |  15 ++
>>  drivers/thermal/thermal_multi.c | 332 ++++++++++++++++++++++++++++++++
>>  include/uapi/linux/thermal.h    |   5 +
>>  4 files changed, 353 insertions(+)
>>  create mode 100644 drivers/thermal/thermal_multi.c
> 
> This does not really build...
> 
> 
> ../drivers/thermal/thermal_multi.c:249:38: error: initialization of ‘struct thermal_trip *’ from incompatible pointer type ‘struct thermal_trip_desc *’ [-Werror=incompatible-pointer-types]

and there are other warnings:

warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst


Best regards,
Krzysztof