Re: [PATCH v5 0/6] Mediatek thermal sensor driver support for MT8186 and MT8188

[Julien Panis]

On 5/24/24 19:19, Russell King (Oracle) wrote:
> On Fri, May 24, 2024 at 01:04:38PM -0400, Nicolas Pitre wrote:
> > On Fri, 24 May 2024, Julien Panis wrote:
> >
> > > [RFC] When PATCH 1/6 and 2/6 are squashed, checkpatch raises this WARNING:
> > > "DT binding docs and includes should be a separate patch." That's why I
> > > split them in this v5. The problem is that the driver can't be compiled
> > > any more at PATCH 1/6. It needs PATCH 2/6 to be compiled. Should the
> > > checkpatch warning be ignored here ? Should I finally squash PATCH 1/6
> > > and PATCH 2/6 ?
> > IMHO it might be preferable to preserve successful compilation across
> > bisection than to appeal to checkpatch in this case.
> Or, patch 1 adds the new definitions, subsequent patches convert the
> users, and the last patch removes the old, now unused, definitions.

Thanks for this suggestion. I'll do something like that in next version.