Re: [PATCH] arm64: dts: qcom: x1e80100: Enable tsens and thermal nodes

From: Dmitry Baryshkov
Date: Mon May 27 2024 - 05:10:53 EST


On Mon, May 27, 2024 at 09:51:17AM +0300, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
>
> Add tsens and thermal nodes for x1e80100 SoC.
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1356 ++++++++++++++++++++++++++++++++
> 1 file changed, 1356 insertions(+)
>

Please review the thermal zones configuration. In some cases trip points
duplicate have their values set to the same temp. In other cases they
have "passive" for 125°C, where it definitely should be "critical", etc.

--
With best wishes
Dmitry