Re: [PATCH] sched/fair: Reschedule the cfs_rq when current is ineligible

From: Mike Galbraith
Date: Mon May 27 2024 - 05:54:28 EST


On Mon, 2024-05-27 at 10:05 +0200, Peter Zijlstra wrote:
> On Sat, May 25, 2024 at 08:41:28AM +0200, Mike Galbraith wrote:
>
> > -       if (pick_eevdf(cfs_rq) == pse)
> > -               goto preempt;
> > -
> > -       return;
> > +       if (pick_eevdf(cfs_rq) == se)
> > +               return;
>
> Right, this will preempt more.

Yeah, and for no tangible benefit that I can see. Repeating the mixed
load GUI vs compute testing a bunch of times, there's enough variance
to swamp any signal.

-Mike