Re: [PATCH v4] clk: imx: imx8mp: Add pm_runtime support for power saving

From: Shengjiu Wang
Date: Mon May 27 2024 - 08:37:08 EST


On Mon, May 27, 2024 at 8:24 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Wed, Apr 24, 2024 at 06:47:25PM +0200, Francesco Dolcini wrote:
> > On Thu, Mar 21, 2024 at 09:14:02PM +0800, Shengjiu Wang wrote:
> > > Add pm_runtime support for power saving. In pm runtime suspend
> > > state the registers will be reseted, so add registers save
> > > in pm runtime suspend and restore them in pm runtime resume.
> > >
> > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > > Reviewed-by: Peng Fan <peng.fan@xxxxxxx>
> >
> > Is this introducing a regression?
> >
> > 800 13:50:19.713052 <6>[ 16.531134] clk: Disabling unused clocks
> > 801 13:50:19.727524 <2>[ 16.535413] SError Interrupt on CPU2, code 0x00000000bf000002 -- SError
> > 802 13:50:19.731400 <4>[ 16.535421] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc5-next-20240424 #1
> > 803 13:50:19.742514 <4>[ 16.535428] Hardware name: Toradex Verdin iMX8M Plus on Dahlia Board (DT)
>
> I am now seeing this failure in mainline on both the above board and
> i.MX8MP-EVK. There was a fix mentioned in the thread but it's not
> landed for -rc1, both boards crash as above. What's the plan for
> getting this fixed, should the patch be reverted for now?

https://lore.kernel.org/all/CAPDyKFp4V8f0iyeRASSEu4YaCSz0m56=8ssBJ9ogSvqG1dzMZA@xxxxxxxxxxxxxx/

fixed is merged, but may not in v6.10-rc1. Should anybody help to cherry-pick?

Best regards
Shengjiu Wang