Re: [PATCH 3/4] drm/sti: tvout: drop driver owner assignment

From: Alain Volmat
Date: Mon May 27 2024 - 11:08:26 EST


Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:30PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> drivers/gpu/drm/sti/sti_tvout.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index 64615638b79a..e714c232026c 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -886,7 +886,6 @@ MODULE_DEVICE_TABLE(of, tvout_of_match);
> struct platform_driver sti_tvout_driver = {
> .driver = {
> .name = "sti-tvout",
> - .owner = THIS_MODULE,
> .of_match_table = tvout_of_match,
> },
> .probe = sti_tvout_probe,
> --
> 2.34.1
>
Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>

Alain