Re: [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for interrupt-names

From: Krzysztof Kozlowski
Date: Mon May 27 2024 - 11:22:26 EST


On 27/05/2024 16:45, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> There's a set of compatibles for which we set a strict list of 5 interrupt
> names even though minItems for the interrupts property is 4. One of the
> USB controllers on sa8775p only consumes 4 interrupts which leads to
> dtbs_check errors. Make the last entry optional by setting minItems to 4.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
> 1 file changed, 1 insertion(+)

Can you also fix other cases? I found there at least two other. I missed
that during review... or maybe we discussed it? I remember that commit
was a pain :/

The commits from quicinc fix one issue and bring immediately one more.

But be sure that this is what we actually want. Maybe intention was to
have fixed number of interrupts (so no minItems in interrupts)?

Also, in any case:
Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in
binding")


Best regards,
Krzysztof