Re: [PATCH v2] wifi: brcm80211: use sizeof(*pointer) instead of sizeof(type)

From: Arend van Spriel
Date: Mon May 27 2024 - 14:09:08 EST


On 5/27/2024 7:34 PM, Erick Archer wrote:
It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

At the same time remove some redundant NULL initializations.

Thanks. The ACK still stands ;-)

Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Erick Archer <erick.archer@xxxxxxxxxxx>
---
Changes in v2:
- Remove some redundant NULL initializations (Arend van Spriel).
- Refactor a bit the logic of "phy_lcn.c" (Arend van Spriel).
- Add the "Acked-by:" tag.

Previous versions:
v1 -> https://lore.kernel.org/linux-hardening/AS8PR02MB7237C3696881F79EAEE8D02E8BF72@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
---
.../broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 ++--
.../broadcom/brcm80211/brcmfmac/btcoex.c | 4 ++--
.../broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
.../broadcom/brcm80211/brcmfmac/usb.c | 6 ++---
.../broadcom/brcm80211/brcmsmac/aiutils.c | 2 +-
.../broadcom/brcm80211/brcmsmac/ampdu.c | 2 +-
.../broadcom/brcm80211/brcmsmac/antsel.c | 2 +-
.../broadcom/brcm80211/brcmsmac/channel.c | 2 +-
.../broadcom/brcm80211/brcmsmac/dma.c | 2 +-
.../broadcom/brcm80211/brcmsmac/mac80211_if.c | 2 +-
.../broadcom/brcm80211/brcmsmac/main.c | 23 +++++++++----------
.../broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 4 ++--
.../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 6 ++---
.../broadcom/brcm80211/brcmsmac/phy_shim.c | 4 ++--
14 files changed, 32 insertions(+), 33 deletions(-)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature