Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue

From: Markus Elfring
Date: Mon May 27 2024 - 14:32:45 EST


> The current interrupt handler in xdma.c was using xdma->stop_request
> before locking the vchan lock.

1. Will an additional imperative wording become helpful here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94

2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?

3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanuph#L124


Regards,
Markus