Re: [PATCH v1 05/11] pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC()
From: kernel test robot
Date: Mon May 27 2024 - 20:20:16 EST
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next linus/master v6.10-rc1 next-20240523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-berlin-Make-use-of-struct-pinfunction/20240528-053304
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20240527212742.1432960-6-andy.shevchenko%40gmail.com
patch subject: [PATCH v1 05/11] pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC()
config: sh-defconfig (https://download.01.org/0day-ci/archive/20240528/202405280739.VSX5oEnr-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240528/202405280739.VSX5oEnr-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405280739.VSX5oEnr-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/pinmux.c:863: warning: Function parameter or struct member 'ngroups' not described in 'pinmux_generic_add_function'
>> drivers/pinctrl/pinmux.c:863: warning: Excess function parameter 'num_groups' description in 'pinmux_generic_add_function'
vim +863 drivers/pinctrl/pinmux.c
a76edc89b100e4 Tony Lindgren 2016-12-27 849
a76edc89b100e4 Tony Lindgren 2016-12-27 850 /**
6bffa7e1631d55 Geert Uytterhoeven 2017-04-03 851 * pinmux_generic_add_function() - adds a function group
a76edc89b100e4 Tony Lindgren 2016-12-27 852 * @pctldev: pin controller device
a76edc89b100e4 Tony Lindgren 2016-12-27 853 * @name: name of the function
a76edc89b100e4 Tony Lindgren 2016-12-27 854 * @groups: array of pin groups
a76edc89b100e4 Tony Lindgren 2016-12-27 855 * @num_groups: number of pin groups
a76edc89b100e4 Tony Lindgren 2016-12-27 856 * @data: pin controller driver specific data
a76edc89b100e4 Tony Lindgren 2016-12-27 857 */
a76edc89b100e4 Tony Lindgren 2016-12-27 858 int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
a76edc89b100e4 Tony Lindgren 2016-12-27 859 const char *name,
bd0aae66c48208 Rafał Miłecki 2021-12-16 860 const char * const *groups,
368512f04e89e0 Andy Shevchenko 2024-05-28 861 const unsigned int ngroups,
a76edc89b100e4 Tony Lindgren 2016-12-27 862 void *data)
a76edc89b100e4 Tony Lindgren 2016-12-27 @863 {
a76edc89b100e4 Tony Lindgren 2016-12-27 864 struct function_desc *function;
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 865 int selector, error;
f913cfce4ee49a Tony Lindgren 2018-07-05 866
f913cfce4ee49a Tony Lindgren 2018-07-05 867 if (!name)
f913cfce4ee49a Tony Lindgren 2018-07-05 868 return -EINVAL;
f913cfce4ee49a Tony Lindgren 2018-07-05 869
f913cfce4ee49a Tony Lindgren 2018-07-05 870 selector = pinmux_func_name_to_selector(pctldev, name);
f913cfce4ee49a Tony Lindgren 2018-07-05 871 if (selector >= 0)
f913cfce4ee49a Tony Lindgren 2018-07-05 872 return selector;
f913cfce4ee49a Tony Lindgren 2018-07-05 873
f913cfce4ee49a Tony Lindgren 2018-07-05 874 selector = pctldev->num_functions;
a76edc89b100e4 Tony Lindgren 2016-12-27 875
a76edc89b100e4 Tony Lindgren 2016-12-27 876 function = devm_kzalloc(pctldev->dev, sizeof(*function), GFP_KERNEL);
a76edc89b100e4 Tony Lindgren 2016-12-27 877 if (!function)
a76edc89b100e4 Tony Lindgren 2016-12-27 878 return -ENOMEM;
a76edc89b100e4 Tony Lindgren 2016-12-27 879
368512f04e89e0 Andy Shevchenko 2024-05-28 880 function = PINCTRL_FUNCTION_DESC(name, groups, ngroups, data);
a76edc89b100e4 Tony Lindgren 2016-12-27 881
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 882 error = radix_tree_insert(&pctldev->pin_function_tree, selector, function);
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 883 if (error)
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 884 return error;
a76edc89b100e4 Tony Lindgren 2016-12-27 885
a76edc89b100e4 Tony Lindgren 2016-12-27 886 pctldev->num_functions++;
a76edc89b100e4 Tony Lindgren 2016-12-27 887
f913cfce4ee49a Tony Lindgren 2018-07-05 888 return selector;
a76edc89b100e4 Tony Lindgren 2016-12-27 889 }
a76edc89b100e4 Tony Lindgren 2016-12-27 890 EXPORT_SYMBOL_GPL(pinmux_generic_add_function);
a76edc89b100e4 Tony Lindgren 2016-12-27 891
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki