Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules

From: Christoph Hellwig
Date: Tue May 28 2024 - 00:58:55 EST


On Mon, May 27, 2024 at 11:24:24PM +0300, Andy Shevchenko wrote:
> Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> variable, the users, which can be compiled as modules, will be failed to
> build. Export the variable to the modules to prevent build breakage.

NAK. Please move dev_is_pnp out of line and export it (as
EXPORT_SYMBOL_GPL), please. bus types should be private unless we have
really good reasons for them not to be private.