Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB

[MD Danish Anwar]

On 28/05/24 3:34 am, Andrew Lunn wrote:
>> +struct mgmt_cmd {
>> +	u8 param;
>> +	u8 seqnum;
>> +	u8 type;
>> +	u8 header;
>> +	u32 cmd_args[3];
>> +} __packed;
> 
> There is a general dislike for __packed. Since your structures are
> naturally well aligned, it is probably not needed. You could be
> paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16);
> 

Sure, I will drop __packed as it's not needed and send next revision.

> 	 Andrew

-- 
Thanks and Regards,
Danish