Re: [PATCH 0/2] cpufreq: qcom-nvmem: fix memory leaks and add auto device node cleanup

From: Viresh Kumar
Date: Tue May 28 2024 - 02:22:32 EST


On 23-05-24, 23:24, Javier Carrasco wrote:
> There are a number of error paths in the probe function that do not call
> of_node_put() to decrement the np device node refcount, leading to
> memory leaks if those errors occur.
>
> In order to ease backporting, the fix has been divided into two patches:
> the first one simply adds the missing calls to of_node_put(), and the
> second one adds the __free() macro to the existing device nodes to
> remove the need for of_node_put(), ensuring that the same bug will not
> arise in the future.
>
> The issue was found by chance while analyzing the code, and I do not
> have the hardware to test it beyond compiling and static analysis tools.
> Although the issue is clear and the fix too, if someone wants to
> volunteer to test the series with real hardware, it would be great.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> Javier Carrasco (2):
> cpufreq: qcom-nvmem: fix memory leaks in probe error paths
> cpufreq: qcom-nvmem: eliminate uses of of_node_put()

Applied. Thanks.

--
viresh