Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device

[Tzung-Bi Shih]

On Tue, May 28, 2024 at 07:41:09AM +0200, Thomas Weißschuh wrote:
> On 2024-05-28 05:37:32+0000, Tzung-Bi Shih wrote:
> > On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote:
> > > +#if IS_ENABLED(CONFIG_MFD_CROS_EC_DEV)
> > [...]
> > > +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm_mfd = {
> > > +	.init = keyboard_led_init_ec_pwm_mfd,
> > > +	.brightness_set_blocking = keyboard_led_set_brightness_ec_pwm,
> > > +	.brightness_get = keyboard_led_get_brightness_ec_pwm,
> > 
> > They are only available if IS_ENABLED(CONFIG_CROS_EC).
> 
> config MFD_CROS_EC_DEV
> 	depends on CROS_EC
> 
> Do you prefer this to be spelled out explicitly somewhere?

I see.  I missed the part.  The dependency is not obvious from only reading
the C file though.