Re: [PATCH] ovl: change error message to info for empty lowerdir

From: Miklos Szeredi
Date: Tue May 28 2024 - 07:35:30 EST


On Tue, 28 May 2024 at 12:55, Eric Curtin <ecurtin@xxxxxxxxxx> wrote:
>
> On Tue, 28 May 2024 at 11:34, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> >
> > On Tue, 28 May 2024 at 11:03, Eric Curtin <ecurtin@xxxxxxxxxx> wrote:
> > >
> > > In some deployments, an empty lowerdir is not considered an error.
> >
> > I don't think this can be triggered in upstream kernel and can be
> > removed completely.
>
> True... Just switched to Fedora Rawhide and instead we just see this one:
>
> pr_err("cannot append lower layer");
>
> >
> > Or do you have a reproducer?
>
> Run one of these vms:
>
> https://github.com/osbuild/bootc-image-builder

Apparently it is using the legacy lowerdir append mode
"lowerdir=:foo". This works only on 6.5.

In 6.6 and later the same can be achieved with "lowerdir+=foo".

It's strange that there are not side effects other then the error message.

Thanks,
Miklos