Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

From: Krzysztof Kozlowski
Date: Tue May 28 2024 - 09:04:23 EST


On 28/05/2024 14:28, Esben Haabendal wrote:
> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
> selected in config snippets.
>
> Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
> ---
> arch/powerpc/configs/85xx-hw.config | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
> index 524db76f47b7..8aff83217397 100644
> --- a/arch/powerpc/configs/85xx-hw.config
> +++ b/arch/powerpc/configs/85xx-hw.config
> @@ -24,6 +24,7 @@ CONFIG_FS_ENET=y
> CONFIG_FSL_CORENET_CF=y
> CONFIG_FSL_DMA=y
> CONFIG_FSL_HV_MANAGER=y
> +CONFIG_FSL_IFC=y

Does not look like placed according to config order. This is not
alphabetically sorted, but as Kconfig creates it (make savedefconfig).

> CONFIG_FSL_PQ_MDIO=y
> CONFIG_FSL_RIO=y


You also missed to update second defconfig - arm64.

Best regards,
Krzysztof