Re: [PATCH 3/3] mm: zswap: make same_filled functions folio-friendly

[Nhat Pham]

On Thu, May 23, 2024 at 8:38 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
>
> A variable name 'page' is used in zswap_is_folio_same_filled() and
> zswap_fill_page() to point at the kmapped data in a folio. Use 'data'
> instead to avoid confusion and stop it from showing up when searching
> for 'page' references in mm/zswap.c.
>
> While we are at it, move the kmap/kunmap calls into zswap_fill_page(),
> make it take in a folio, and rename it to zswap_fill_folio().
>
> Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>

Seems reasonable to me.
Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx>