Re: [PATCH v2] hwmon: (max6639) : Update hwmon init using info
From: kernel test robot
Date: Tue May 28 2024 - 12:03:15 EST
Hi Naresh,
kernel test robot noticed the following build errors:
[auto build test ERROR on 5fbf8734fb36cf67339f599f0e51747a6aff690c]
url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-max6639-Update-hwmon-init-using-info/20240528-172245
base: 5fbf8734fb36cf67339f599f0e51747a6aff690c
patch link: https://lore.kernel.org/r/20240528091808.863702-1-naresh.solanki%409elements.com
patch subject: [PATCH v2] hwmon: (max6639) : Update hwmon init using info
config: arm64-randconfig-002-20240528 (https://download.01.org/0day-ci/archive/20240528/202405282323.3IOCxxpg-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240528/202405282323.3IOCxxpg-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405282323.3IOCxxpg-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/hwmon/max6639.c:291:3: error: expected expression
u8 x;
^
>> drivers/hwmon/max6639.c:296:3: error: use of undeclared identifier 'x'
x = val & MAX6639_FAN_CONFIG3_FREQ_MASK;
^
drivers/hwmon/max6639.c:303:4: error: use of undeclared identifier 'x'
x |= 0x4;
^
drivers/hwmon/max6639.c:304:3: error: use of undeclared identifier 'x'
x &= 0x7;
^
drivers/hwmon/max6639.c:305:25: error: use of undeclared identifier 'x'
*pwm_val = freq_table[x];
^
drivers/hwmon/max6639.c:328:3: error: expected expression
u8 x;
^
drivers/hwmon/max6639.c:332:8: error: use of undeclared identifier 'x'
for (x = 0; x < sizeof(freq_table); x++)
^
drivers/hwmon/max6639.c:332:15: error: use of undeclared identifier 'x'
for (x = 0; x < sizeof(freq_table); x++)
^
drivers/hwmon/max6639.c:332:39: error: use of undeclared identifier 'x'
for (x = 0; x < sizeof(freq_table); x++)
^
drivers/hwmon/max6639.c:333:26: error: use of undeclared identifier 'x'
if (val <= freq_table[x])
^
drivers/hwmon/max6639.c:337:38: error: use of undeclared identifier 'x'
MAX6639_FAN_CONFIG3_FREQ_MASK, x);
^
drivers/hwmon/max6639.c:341:7: error: use of undeclared identifier 'x'
if (x >> 2)
^
12 errors generated.
vim +291 drivers/hwmon/max6639.c
275
276 static int max6639_read_pwm(struct device *dev, u32 attr, int channel,
277 long *pwm_val)
278 {
279 struct max6639_data *data = dev_get_drvdata(dev);
280 unsigned int val, res;
281
282 if (IS_ERR(data))
283 return PTR_ERR(data);
284
285 switch (attr) {
286 case hwmon_pwm_input:
287 res = regmap_read(data->regmap, MAX6639_REG_TARGTDUTY(channel), &val);
288 *pwm_val = val * 255 / 120;
289 return 0;
290 case hwmon_pwm_freq:
> 291 u8 x;
292
293 res = regmap_read(data->regmap, MAX6639_REG_FAN_CONFIG3(channel), &val);
294 if (res < 0)
295 return res;
> 296 x = val & MAX6639_FAN_CONFIG3_FREQ_MASK;
297
298 res = regmap_read(data->regmap, MAX6639_REG_GCONFIG, &val);
299 if (res < 0)
300 return res;
301
302 if (val & MAX6639_GCONFIG_PWM_FREQ_HI)
303 x |= 0x4;
304 x &= 0x7;
305 *pwm_val = freq_table[x];
306 return res;
307 default:
308 return -EOPNOTSUPP;
309 }
310 }
311
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki