Re: [PATCH 3/3] arm64: dts: qcom: sdm450: add Lenovo Smart Tab M10 DTS

[Bjorn Andersson]

On Tue, May 28, 2024 at 02:19:28PM GMT, Konrad Dybcio wrote:
> 
> 
> On 5/27/24 18:33, Bjorn Andersson wrote:
> > On Thu, May 23, 2024 at 09:59:35AM GMT, Neil Armstrong wrote:
> > > diff --git a/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts b/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts
> > [..]
> > > +&rpm_requests {
> > > +	regulators {
> > > +		compatible = "qcom,rpm-pm8953-regulators";
> > [..]
> > > +		pm8953_l8: l8 {
> > > +			regulator-min-microvolt = <2900000>;
> > > +			regulator-max-microvolt = <2900000>;
> > > +		};
> > [..]
> > > +		pm8953_l11: l11 {
> > > +			regulator-min-microvolt = <3300000>;
> > > +			regulator-max-microvolt = <3300000>;
> > > +		};
> > [..]
> > > +	};
> > > +};
> > > +
> > > +&sdhc_1 {
> > > +	vmmc-supply = <&pm8953_l8>;
> > 
> > JFYI. Not ensuring that the vmmc-supply is in HPM mode bitten us
> > multiple times in the past.
> 
> it's not rpmh ;)
> 

Here are a few non-rpmh examples of us being bitten...

e38161bd325e ("arm64: dts: apq8096-db820c: Increase load on l21 for SDCARD")
03864e57770a ("ARM: dts: qcom: msm8974-hammerhead: increase load on l20 for sdhci")
27fe0fc05f35 ("ARM: dts: msm8974-FP2: Increase load on l20 for sdhci")

..taken care of by forcing the relevant regulators into HPM.

Regards,
Bjorn