Re: [PATCH v2] selftests/net: suppress clang's "variable-sized type not at the end" warning

[John Hubbard]

On 5/28/24 1:39 PM, Nathan Chancellor wrote:
> On Mon, May 27, 2024 at 02:36:41PM -0700, John Hubbard wrote:
..
> > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> > index bd01e4a0be2c..9a3b766c8781 100644
> > --- a/tools/testing/selftests/net/Makefile
> > +++ b/tools/testing/selftests/net/Makefile
> > @@ -6,6 +6,10 @@ CFLAGS += -I../../../../usr/include/ $(KHDR_INCLUDES)
> >   # Additional include paths needed by kselftest.h
> >   CFLAGS += -I../
> >   
> > +ifneq ($(LLVM),)
> > +    CFLAGS += -Wno-gnu-variable-sized-type-not-at-end
>
> For what it's worth, the main kernel has -Wno-gnu because there is
> little point in warning about the use of GNU extensions when building
> with '-std=gnu...'. It may be worth doing this anywhere that uses a GNU
> standard in the selftests but I guess it depends on how noisy things
> are.

I think there might be one or two other cases like this that I haven't
gotten around to, so yes you are right, this probably should be moved
into lib.mk instead.

I'll do that in a v3.

> > +endif
> > +
> >   TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh \
> >   	      rtnetlink.sh xfrm_policy.sh test_blackhole_dev.sh
> >   TEST_PROGS += fib_tests.sh fib-onlink-tests.sh pmtu.sh udpgso.sh ip_defrag.sh
> >
> > base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> > --
> > 2.45.1

thanks,
--
John Hubbard
NVIDIA