Re: [PATCH v2] statx: stx_subvol

[Andreas Dilger]

> On May 28, 2024, at 6:46 AM, John Garry <john.g.garry@xxxxxxxxxx> wrote:
> 
> On 12/03/2024 02:13, Eric Biggers wrote:
>> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote:
>>>  	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
>>>  	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
>>> +	__u64	stx_subvol;	/* Subvolume identifier */
>>>  	/* 0xa0 */
>>> -	__u64	__spare3[12];	/* Spare space for future expansion */
>>> +	__u64	__spare3[11];	/* Spare space for future expansion */
>>>  	/* 0x100 */
>> The /* 0xa0 */ comment needs to be updated (or deleted).
> 
> I would tend to agree. Was this intentionally not updated (or deleted)?

More correct would be to add the new stx_subvol field after the "0xa0"
comment so that it is clear at what offset in the struct this field is.

Cheers, Andreas

Attachment: signature.asc
Description: Message signed with OpenPGP