Re: [PATCH v2 4/4] remoteproc: qcom_q6v5_pas: Add hwspinlock bust on stop

[Bjorn Andersson]

On Fri, May 24, 2024 at 06:26:43PM -0700, Chris Lew wrote:
> From: Richard Maina <quic_rmaina@xxxxxxxxxxx>
> 
> When remoteproc goes down unexpectedly this results in a state where any
> acquired hwspinlocks will remain locked possibly resulting in deadlock.
> In order to ensure all locks are freed we include a call to
> qcom_smem_bust_hwspin_lock_by_host() during remoteproc shutdown.
> 
> For qcom_q6v5_pas remoteprocs, each remoteproc has an assigned smem
> host_id. Remoteproc can pass this id to smem to try and bust the lock on
> remoteproc stop.
> 
> This edge case only occurs with q6v5_pas watchdog crashes. The error
> fatal case has handling to clear the hwspinlock before the error fatal
> interrupt is triggered.
> 
> Signed-off-by: Richard Maina <quic_rmaina@xxxxxxxxxxx>
> Signed-off-by: Chris Lew <quic_clew@xxxxxxxxxxx>

Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>

Regards,
Bjorn