RE: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver

[Delphine_CC_Chiu/WYHQ/Wiwynn]

Hi,

> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: Monday, May 27, 2024 5:11 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>; David
> S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver
> 
>  [External Sender]
> 
> Hi,
> 
> On Wed, 2024-05-22 at 09:25 +0800, DelphineCCChiu wrote:
> > Currently NCSI driver will send several NCSI commands back to back
> > without waiting the response of previous NCSI command or timeout in
> > some state when NIC have multi channel. This operation against the
> > single thread manner defined by NCSI SPEC(section 6.3.2.3 in
> > DSP0222_1.1.1)
> >
> > According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1), we should
> > probe one channel at a time by sending NCSI commands (Clear initial
> > state, Get version ID, Get capabilities...), than repeat this steps
> > until the max number of channels which we got from NCSI command (Get
> > capabilities) has been probed.
> >
> > Signed-off-by: DelphineCCChiu <delphine_cc_chiu@xxxxxxxxxx>
> 
> As noted by Jakub, this looks like a fix. Please include a suitable Fixes tag in the
> tag area and the target tree 'net' inside the subject prefix.
> 
> Thanks!
> 
> Paolo

I have sent a V3 patch which contain Fixes tag and added 'net' in subject prefix.

Thanks!