Re: [PATCH v3 4/6] dt-bindings: thermal: Add a property to select the aggregation type

[Alexandre Bailon]

On 5/27/24 08:55, Krzysztof Kozlowski wrote:
> On 24/05/2024 16:31, Alexandre Bailon wrote:
> > This adds a new property named "aggregation" that could be used to
> > select the aggregation type when there are multiple sensors assigned
> > to a thermal zone.
> >
> > Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/thermal/thermal-zones.yaml        | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > index fa7a72e2ba44..e6e4b46773e3 100644
> > --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > @@ -111,6 +111,14 @@ patternProperties:
> >             coefficients are ordered and are matched with sensors by means of the
> >             sensor ID. Additional coefficients are interpreted as constant offset.
> >   
> > +      aggregation:
> > +        $ref: /schemas/types.yaml#/definitions/string
> > +        enum:
> > +          - avg
> > +          - max
> > +        description:
> > +          Aggregation type to use compute a temperature from multiple sensors.
>
> Hm, why exactly this is a property of hardware? Why on one board you
> would like to average and on other use max? I can only think of a case
> that some sensors give inaccurate data. Otherwise it is OS policyIn the case of Mediatek SoC, we only need max temperature.
I am not really sure if there is really an use case for the average.
Maybe I should drop average if no-one has a use case for it.

Best Regards,
Alexandre
> Best regards,
> Krzysztof