Re: [PATCH MANUALSEL 4.19 1/2] KVM: x86: Handle SRCU initialization failure during page track init

From: Zenghui Yu
Date: Wed May 29 2024 - 04:35:16 EST


On 2021/10/6 19:23, Paolo Bonzini wrote:
On 06/10/21 13:12, Sasha Levin wrote:
> From: Haimin Zhang <tcs_kernel@xxxxxxxxxxx>
>
> [ Upstream commit eb7511bf9182292ef1df1082d23039e856d1ddfb ]
>
> Check the return of init_srcu_struct(), which can fail due to OOM, when
> initializing the page track mechanism.  Lack of checking leads to a NULL
> pointer deref found by a modified syzkaller.
>
> Reported-by: TCS Robot <tcs_robot@xxxxxxxxxxx>
> Signed-off-by: Haimin Zhang <tcs_kernel@xxxxxxxxxxx>
> Message-Id: <1630636626-12262-1-git-send-email-tcs_kernel@xxxxxxxxxxx>
> [Move the call towards the beginning of kvm_arch_init_vm. - Paolo]
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Sasha, will this patch be applied for 4.19?

The same question for the 5.4 backport [*]. It looks like both of them
are missed for unknown reasons.

[*] https://lore.kernel.org/stable/20211006111250.264294-1-sashal@xxxxxxxxxx