Re: [PATCH net] ipv4: correctly iterate over the target netns in inet_dump_ifaddr()

[Aleksandr Mikhalitsyn]

On Wed, May 29, 2024 at 10:29 AM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> On Wed, May 29, 2024 at 9:49 AM Christian Brauner <brauner@kernelorg> wrote:
> >
> > On Tue, May 28, 2024 at 10:30:30PM +0200, Alexander Mikhalitsyn wrote:
> > > A recent change to inet_dump_ifaddr had the function incorrectly iterate
> > > over net rather than tgt_net, resulting in the data coming for the
> > > incorrect network namespace.
> > >
> > > Fixes: cdb2f80f1c10 ("inet: use xa_array iterator to implement inet_dump_ifaddr()")
> > > Reported-by: Stéphane Graber <stgraber@xxxxxxxxxxxx>
> > > Closes: https://github.com/lxc/incus/issues/892
> > > Bisected-by: Stéphane Graber <stgraber@xxxxxxxxxxxx>
> > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonicalcom>
> > > Tested-by: Stéphane Graber <stgraber@xxxxxxxxxxxx>
> > > ---
> >
> > Acked-by: Christian Brauner <brauner@xxxxxxxxxx>
>
> Thanks a lot for the bisection and the fix !

Thanks, Eric!

>
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>