Re: [PATCH v3 3/6] iio: adc: ad7173: refactor ain and vref selection

[Nuno Sá]

On Wed, 2024-05-29 at 14:27 +0200, Nuno Sá wrote:
> On Mon, 2024-05-27 at 20:02 +0300, Dumitru Ceclan via B4 Relay wrote:
> > From: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> > 
> > Move validation of analog inputs and reference voltage selection to
> > separate functions to reduce the size of the channel config parsing
> > function and improve readability.
> > 
> > Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> > ---
> >  drivers/iio/adc/ad7173.c | 62 ++++++++++++++++++++++++++++++++++--------------
> >  1 file changed, 44 insertions(+), 18 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index 9e507e2c66f0..8a53821c8e58 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -906,6 +906,44 @@ static int ad7173_register_clk_provider(struct iio_dev
> > *indio_dev)
> >  					   &st->int_clk_hw);
> >  }
> >  
> > +static int ad7173_validate_voltage_ain_inputs(struct ad7173_state *st,
> > +					      unsigned int ain[2])

Pass the pointer and size of it... Also, it should be made 'const'

> > +{
> > +	struct device *dev = &st->sd.spi->dev;
> > +
> > +	for (int i = 0; i < 2; i++) {

Use the size in here... At the very least, ARRAY_SIZE() if you keep it like this.

> > +		if (ain[i] < st->info->num_inputs)
> > +			continue;
> > +
> > +		return dev_err_probe(dev, -EINVAL,
> > +			"Input pin number out of range for pair (%d %d).\n",
> > +			ain[0], ain[1]);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> > +static int ad7173_validate_reference(struct ad7173_state *st, int ref_sel)
> > +{
> > +	struct device *dev = &st->sd.spi->dev;
> > +	int ret;
> > +
> > +	if (ref_sel == AD7173_SETUP_REF_SEL_INT_REF && !st->info->has_int_ref)
> > +		return dev_err_probe(dev, -EINVAL,
> > +			"Internal reference is not available on current
> > model.\n");
> > +
> > +	if (ref_sel == AD7173_SETUP_REF_SEL_EXT_REF2 && !st->info->has_ref2)
> > +		return dev_err_probe(dev, -EINVAL,
> > +			"External reference 2 is not available on current
> > model.\n");
> > +
> > +	ret = ad7173_get_ref_voltage_milli(st, ref_sel);
> > +	if (ret < 0)
> > +		return dev_err_probe(dev, ret, "Cannot use reference %u\n",
> > +				     ref_sel);
> > +
> > +	return 0;
> 
> If you need a v4, I would just 'return ad7173_get_ref_voltage_milli(...)' Any
> error
> log needed should be done inside ad7173_get_ref_voltage_milli(). Anyways:
> 
> Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> 

In fact, no tag :). Just realized the above in another patch..

- Nuno Sá