RE: [PATCH v2] drivers: iio: adc: add support for ad777x family

[Nechita, Ramona]

Hello,

It misses a chunk of it because part of the code added there was not meant for upstreaming due to the axi interface.

Best Regards,
Ramona

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 
Sent: Wednesday, May 29, 2024 6:13 PM
To: Nechita, Ramona <Ramona.Nechita@xxxxxxxxxx>
Cc: linux-iio@xxxxxxxxxxxxxxx; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@analogcom>; Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Schmitt, Marcelo <Marcelo.Schmitt@xxxxxxxxxx>; Marius Cristea <marius.cristea@xxxxxxxxxxxxx>; Maksim Kiselev <bigunclemax@xxxxxxxxx>; Marcus Folkesson <marcus.folkesson@xxxxxxxxx>; Sahin, Okan <Okan.Sahin@xxxxxxxxxx>; Mike Looijmans <mike.looijmans@xxxxxxxx>; Liam Beguin <liambeguin@xxxxxxxxx>; Ivan Mikhaylov <fr0st61te@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] drivers: iio: adc: add support for ad777x family

[External]

On Wed, May 29, 2024 at 06:03:09PM +0300, ranechita wrote:
> Added support for ad7770,ad7771,ad7779 ADCs. The data is streamed only 
> on the spi-mode, without using the data lines.

Do not send new version if we have not settled down everything in the previous review round, hence I even won't bother to look into the code. Will wait your replies in v1 and, when we got into agreement, v3 after that.

> Signed-off-by: ranechita <ramona.nechita@xxxxxxxxxx>
> ---

This misses a lot of information I asked about in the v1 round of review.

--
With Best Regards,
Andy Shevchenko