Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own file

From: Tom Lendacky
Date: Wed May 29 2024 - 12:50:38 EST


On 5/29/24 11:22, Mario Limonciello wrote:
On 5/29/2024 10:20, Tom Lendacky wrote:
On 5/28/24 16:07, Mario Limonciello wrote:
To prepare for other code that will manipulate security attributes
move the handling code out of sp-pci.c. No intended functional changes.

Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
v1->v2:
  * Only add psp_security_attr_group when PSP support enabled
    (Fixes lkp robot reported Kconfig issue)

Just verifying that there's no change in behavior in regards to whether the attributes are shown. Previously the attributes were not shown if CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would be NULL in psp_security_is_visible(), right?

Yes; that's right.

Acked-by: Tom Lendacky <thomas.lendacky@xxxxxxx>