Re: [PATCH v4 06/16] selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope

From: Reinette Chatre
Date: Wed May 29 2024 - 13:44:36 EST


Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
'bm_pid' and 'ppid' are global variables. As they are used by different
processes and in signal handler, they cannot be entirely converted into
local variables.

The scope of those variables can still be reduced into resctrl_val.c
only. As PARENT_EXIT() macro is using 'ppid', make it a function in
resctrl_val.c and pass ppid to it as an argument because it is easier
to understand than using the global variable directly.

Pass 'bm_pid' into measure_val() instead of relying on the global
variable which helps to make the call signatures of measure_val() and
measure_llc_resctrl() more similar to each other.

measure_val() -> measure_vals() (in two places above)


Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
---

With typos fixed:

| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette