Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

[Himanshu Madhani]

On 5/28/24 14:56, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---
>   drivers/scsi/qla2xxx/qla_isr.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
>   	}
>   }
>   
> -struct scsi_dif_tuple {
> -	__be16 guard;       /* Checksum */
> -	__be16 app_tag;         /* APPL identifier */
> -	__be32 ref_tag;         /* Target LBA or indirect LBA */
> -};
> -
>   /*
>    * Checks the guard or meta-data for the type of error
>    * detected by the HBA. In case of errors, we set the

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani                                Oracle Linux Engineering