Re: [net-next PATCH v4 2/7] net: ravb: Consider busypolling status when re-enabling interrupts

From: Paul Barker
Date: Wed May 29 2024 - 15:09:27 EST


On 28/05/2024 17:47, Sergey Shtylyov wrote:
> On 5/28/24 7:44 PM, Sergey Shtylyov wrote:
>
>>> Make use of the busypolling status returned from NAPI complete to decide
>>
>> My spellchecker/translator trip over "busypolling" -- consider using
>> "busy-polling"?
>> And did you actually mean napi_complete_done()?
>
> Ah, napi_complete() also returns a result... maybe this should be reworded
> as "NAPI completion"?
>
>>> if interrupts shall be re-enabled or not. This is useful to reduce the
>>> interrupt overhead.
>>>
>>> While at it switch to using napi_complete_done() as it take into account
>>
>> Takes.
>>
>>> the work done when providing the busypolling status.
>>
>> Again, "busy-polling"?

Ack to all of the above.

I used the commit message suggested by Niklas here. I'll revise it a
little for v5...

Thanks,

--
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature