Re: [PATCH] tools/testing/selftests/livepatch: define max test-syscall processes

From: Marcos Paulo de Souza
Date: Wed May 29 2024 - 17:09:27 EST


From: mpdesouza@xxxxxxxx

On Wed, 29 May 2024 16:19:41 -0400 Ryan Sullivan <rysulliv@xxxxxxxxxx> wrote:

> Define a maximum allowable number of pids that can be livepatched in
> test-syscall.sh as with extremely large machines the output from a
> large number of processes overflows the dev/kmsg "expect" buffer in
> the "check_result" function and causes a false error.

I believe that 128 threads hammering getpid is good enough :)

Tested-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
Reviewed-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>

>
> Reported-by: CKI Project <cki-project@xxxxxxxxxx>
> Signed-off-by: Ryan Sullivan <rysulliv@xxxxxxxxxx>
> ---
> tools/testing/selftests/livepatch/test-syscall.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/livepatch/test-syscall.sh b/tools/testing/selftests/livepatch/test-syscall.sh
> index b76a881d4013..289eb7d4c4b3 100755
> --- a/tools/testing/selftests/livepatch/test-syscall.sh
> +++ b/tools/testing/selftests/livepatch/test-syscall.sh
> @@ -15,7 +15,10 @@ setup_config
>
> start_test "patch getpid syscall while being heavily hammered"
>
> -for i in $(seq 1 $(getconf _NPROCESSORS_ONLN)); do
> +NPROC=$(getconf _NPROCESSORS_ONLN)
> +MAXPROC=128
> +
> +for i in $(seq 1 $(($NPROC < $MAXPROC ? $NPROC : $MAXPROC))); do
> ./test_klp-call_getpid &
> pids[$i]="$!"
> done
> --
> 2.44.0