[PATCH v3 0/7] drm/msm: make use of the HDMI connector infrastructure

From: Dmitry Baryshkov
Date: Wed May 29 2024 - 19:12:40 EST


This patchset sits on top Maxime's HDMI connector patchset ([1]).

Currently this is an RFC exploring the interface between HDMI bridges
and HDMI connector code. This has been lightly verified on the Qualcomm
DB820c, which has native HDMI output. If this approach is considered to
be acceptable, I'll finish MSM HDMI bridge conversion (reworking the
Audio Infoframe code). Other bridges can follow the same approach (we
have lt9611 / lt9611uxc / adv7511 on Qualcomm hardware).

[1] https://patchwork.freedesktop.org/series/122421/

To: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
To: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
To: Robert Foss <rfoss@xxxxxxxxxx>
To: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
To: Jonas Karlman <jonas@xxxxxxxxx>
To: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
To: Maxime Ripard <mripard@xxxxxxxxxx>
To: Thomas Zimmermann <tzimmermann@xxxxxxx>
To: David Airlie <airlied@xxxxxxxxx>
To: Daniel Vetter <daniel@xxxxxxxx>
To: Rob Clark <robdclark@xxxxxxxxx>
To: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
To: Sean Paul <sean@xxxxxxxxxx>
To: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-arm-msm@xxxxxxxxxxxxxxx
Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Changes in v3:
- Rebased on top of the merged HDMI connector patchset.
- Changed drm_bridge_connector to use drmm_connector_init() (Maxime)
- Added a check that write_infoframe callback is present if
BRIDGE_OP_HDMI is set.
- Moved drm_atomic_helper_connector_hdmi_check() call from
drm_bridge_connector to the HDMI bridge driver to remove dependency
from drm_kms_helpers on the optional HDMI state helpers.
- Converted Audio InfoFrame handling code.
- Added support for HDMI Vendor Specific and SPD InfoFrames.
- Link to v2: https://lore.kernel.org/r/20240309-bridge-hdmi-connector-v2-0-1380bea3ee70@xxxxxxxxxx

Changes in v2:
- Dropped drm_connector_hdmi_setup(). Instead added
drm_connector_hdmi_init() to be used by drm_bridge_connector.
- Changed the drm_bridge_connector to act as a proxy for the HDMI
connector infrastructure. This removes most of the logic from
the bridge drivers.
- Link to v1: https://lore.kernel.org/r/20240308-bridge-hdmi-connector-v1-0-90b693550260@xxxxxxxxxx

---
Dmitry Baryshkov (7):
drm/connector: hdmi: accept NULL for Audio Infoframe
drm/bridge-connector: switch to using drmm allocations
drm/bridge-connector: implement glue code for HDMI connector
drm/msm/hdmi: switch to atomic bridge callbacks
drm/msm/hdmi: make use of the drm_connector_hdmi framework
drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition
drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

drivers/gpu/drm/display/drm_hdmi_state_helper.c | 14 +-
drivers/gpu/drm/drm_bridge_connector.c | 114 ++++++++--
drivers/gpu/drm/drm_debugfs.c | 2 +
drivers/gpu/drm/msm/Kconfig | 2 +
drivers/gpu/drm/msm/hdmi/hdmi.c | 44 +---
drivers/gpu/drm/msm/hdmi/hdmi.h | 16 +-
drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 74 ++-----
drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 271 ++++++++++++++++++++----
drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +-
include/drm/drm_bridge.h | 82 +++++++
10 files changed, 455 insertions(+), 166 deletions(-)
---
base-commit: 03e98b48e2125d0cc99eeaace0f06290e20a1c55
change-id: 20240307-bridge-hdmi-connector-7e3754e661d0

Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>