Re: [PATCH net-next] net: smc91x: Refactor SMC_* macros

From: Jakub Kicinski
Date: Wed May 29 2024 - 20:18:32 EST


On Tue, 28 May 2024 12:44:23 +0200 Thorsten Blum wrote:
> Use the macro parameter lp directly instead of relying on ioaddr being
> defined in the surrounding scope.

Have you tested this, or just compile tested (please mention what
testing has been done in the commit message in the future)?

What's the motivation - cleanup or this helps remove some warnings?
(again, please mention in the commit message)

AFAICT this will break smc_probe().
--
pw-bot: cr