Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

[Ricard Wanderlof]

On Tue, 28 May 2024, Dmitry Baryshkov wrote:

> On Tue, May 28, 2024 at 12:04:49PM +0200, Ricard Wanderlof wrote:
> > 
> > Even though data is truncated to 24 bits, the I2S interface does
> > accept 32 bit data (the slot widths according to the data sheet
> > can be 16 or 32 bits) so let the hw_params callback reflect this,
> > even if the lowest 8 bits are not used when 32 bits are specified.
> ...
> > ---
> >  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 
> What about:
> 
> Fixes: ae053fa234f4 ("drm: bridge: adv7511: Support I2S IEC958 encoded PCM format")
> 
> ?

IMHO, commit ae053fa234f4 doesn't break anything, so there's nothing to be 
fixed. It adds S/PDIF support, which uses a 32 bit format, but the 32 bit 
format was not supported at all prior to that commit.

I don't really have a problem adding the Fixes tag if you think it's 
useful, but it doesn't seem quite right to me.

/Ricard
-- 
Ricard Wolf Wanderlof                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30