Re: [PATCH net] net: dsa: microchip: fix wrong register write when masking interrupt
From: Paolo Abeni
Date: Thu May 30 2024 - 04:57:06 EST
On Tue, 2024-05-28 at 14:35 -0700, Tristram.Ha@xxxxxxxxxxxxx wrote:
> From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>
>
> The initial code used 32-bit register. After that it was changed to 0x1F
> so it is no longer appropriate to use 32-bit write.
IMHO the above sentence is too much unclear. It sort of implies that
the currently used register is 8 bit wide because such register address
can be represented with 8 bit - which in turn sounds weird or
irrelevant.
I guess some documentation describes register 0x1F, please rephrase the
changelog accordingly.
Thanks,
Paolo