Re: [PATCH v2 0/3] gpiolib: cdev: tidy up kfifo handling

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>


On Wed, 29 May 2024 21:19:50 +0800, Kent Gibson wrote:
> This series is a follow up to my recent kfifo initialisation fix[1].
> 
> Patch 1 adds calling INIT_KFIFO() on the event kfifo in order to induce
> an oops if the kfifo is accessed prior to being allocated.  Not calling
> INIT_KFIFO() could be considered an abuse of the kfifo API. I don't
> recall, but it is possible that it was not being called as we also make
> use of kfifo_initialized(), and the assumption was that it would return
> true after the INIT_KFIFO() call. In fact it only returns true once
> the kfifo has been allocated.
> 
> [...]

Applied, thanks!

[1/3] gpiolib: cdev: Add INIT_KFIFO() for linereq events
      commit: 35d848e7a1cbba2649ed98cf58e0cdc7ee560c7a
[2/3] gpiolib: cdev: Refactor allocation of linereq events kfifo
      commit: 4ce5ca654a761462a222164e96b8ab953b8cacab
[3/3] gpiolib: cdev: Cleanup kfifo_out() error handling
      commit: 2ba4746b418dcffadb3b135657fea8d3e62b4c30

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>