Re: [net-next PATCH v4 7/7] net: ravb: Allocate RX buffers via page pool

[Paul Barker]

On 30/05/2024 10:21, Paul Barker wrote:
> On 29/05/2024 21:52, Sergey Shtylyov wrote:
>> On 5/28/24 6:03 PM, Paul Barker wrote:
>>> @@ -865,7 +894,16 @@ static int ravb_rx_gbeth(struct net_device *ndev, int budget, int q)
>>>  				stats->rx_bytes += skb->len;
>>>  				napi_gro_receive(&priv->napi[q], skb);
>>>  				rx_packets++;
>>> +
>>> +				/* Clear rx_1st_skb so that it will only be
>>> +				 * non-NULL when valid.
>>> +				 */
>>> +				if (die_dt == DT_FEND)
>>> +					priv->rx_1st_skb = NULL;
>>
>>    Hm, can't we do this under *case* DT_FEND above?
> 
> It makes more logical sense to me to do this as the last step, but I
> guess it's a little more optimal to do it earlier. I'll move it.

Actually, this doesn't even need to be conditional. If die_dt is
DT_FSINGLE, priv->rx_1st_skb will already be NULL so this will be a
no-op. So I'll just simplify this.

Thanks,

-- 
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature