RE: [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to builtin symbol

[Sai Krishna Gajula]

> -----Original Message-----
> From: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Sent: Wednesday, May 29, 2024 3:10 PM
> To: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>; Broadcom internal kernel
> review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>; Andrew Lunn
> <andrew@xxxxxxx>; Heiner Kallweit <hkallweit1@xxxxxxxxx>; Russell King
> <linux@xxxxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> Radu Pirea <radu-nicolae.pirea@xxxxxxxxxxx>; Jay Vosburgh
> <j.vosburgh@xxxxxxxxx>; Andy Gospodarek <andy@xxxxxxxxxxxxx>; Nicolas
> Ferre <nicolas.ferre@xxxxxxxxxxxxx>; Claudiu Beznea
> <claudiu.beznea@xxxxxxxxx>; Willem de Bruijn
> <willemdebruijn.kernel@xxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>;
> Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>;
> UNGLinuxDriver@xxxxxxxxxxxxx; Simon Horman <horms@xxxxxxxxxx>;
> Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>;
> Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx>; Kory Maincent
> <kory.maincent@xxxxxxxxxxx>
> Subject: [PATCH net-next v13 12/14] net: ptp: Move
> ptp_clock_index() to builtin symbol
> 
> Move ptp_clock_index() to builtin symbols to prepare for supporting get and
> set hardware timestamps from ethtool, which is builtin.
> 
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
> 
> Change in v13:
> - New patch
> ---
>  drivers/ptp/ptp_clock.c          | 6 ------
>  drivers/ptp/ptp_clock_consumer.c | 6 ++++++
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index
> 593b5c906314..fc4b266abe1d 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -460,12 +460,6 @@ void ptp_clock_event(struct ptp_clock *ptp, struct
> ptp_clock_event *event)  }  EXPORT_SYMBOL(ptp_clock_event);
> 
> -int ptp_clock_index(struct ptp_clock *ptp) -{
> -	return ptp->index;
> -}
> -EXPORT_SYMBOL(ptp_clock_index);
> -
>  int ptp_find_pin(struct ptp_clock *ptp,
>  		 enum ptp_pin_function func, unsigned int chan)  { diff --git
> a/drivers/ptp/ptp_clock_consumer.c b/drivers/ptp/ptp_clock_consumer.c
> index 759dd6f63405..2322fa65075e 100644
> --- a/drivers/ptp/ptp_clock_consumer.c
> +++ b/drivers/ptp/ptp_clock_consumer.c
> @@ -97,3 +97,9 @@ void ptp_clock_put(struct device *dev, struct ptp_clock
> *ptp)
>  	put_device(&ptp->dev);
>  	module_put(ptp->info->owner);
>  }
> +
> +int ptp_clock_index(struct ptp_clock *ptp) {
> +	return ptp->index;
> +}
> +EXPORT_SYMBOL(ptp_clock_index);
> 
Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors.
> --
> 2.34.1
>