Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

[Guenter Roeck]

On 5/30/24 03:51, Thomas Weißschuh wrote:
> On 2024-05-29 13:52:03+0000, Guenter Roeck wrote:
> > Add support for SPD5118 (Jedec JESD300-5B.01) compliant temperature
> > sensors. Such sensors are typically found on DDR5 memory modules.
> >
> > Cc: René Rebe <rene@xxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > Tested on MAG B650 TOMAHAWK WIFI with CMH32GX5M2B6000Z30
> > (Corsair Venegance DDR5).
> >
> > René: I included you as MODULE_AUTHOR since the patch is derived from
> >        your driver. Please let me know if you prefer not to be listed as
> >        author.
> >
> >   Documentation/hwmon/index.rst   |   1 +
> >   Documentation/hwmon/spd5118.rst |  60 ++++
> >   drivers/hwmon/Kconfig           |  12 +
> >   drivers/hwmon/Makefile          |   1 +
> >   drivers/hwmon/spd5118.c         | 482 ++++++++++++++++++++++++++++++++
> >   5 files changed, 556 insertions(+)
> >   create mode 100644 Documentation/hwmon/spd5118.rst
> >   create mode 100644 drivers/hwmon/spd5118.c
>
> With the Makefile and detect callback fixed:
>
> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> Tested-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Thanks a lot for the feedback!

If it is not too much trouble, could you send me a register dump ?
The one I have is from Montage Technology M88SPD5118, and I'd like to get
a few more to improve my module test script.

Thanks,
Guenter